OpenSSF Scorecard plugin expansion + RSFC plugin docker image update and new indicator#69
Open
andriumon wants to merge 3 commits intoEVERSE-ResearchSoftware:mainfrom
Open
OpenSSF Scorecard plugin expansion + RSFC plugin docker image update and new indicator#69andriumon wants to merge 3 commits intoEVERSE-ResearchSoftware:mainfrom
andriumon wants to merge 3 commits intoEVERSE-ResearchSoftware:mainfrom
Conversation
dgarijo
requested changes
Apr 21, 2026
| indicators = [ | ||
| "has_ci_tests", | ||
| "human_code_review_requirement", | ||
| "has_published_package", |
There was a problem hiding this comment.
you add new indicators, but they are not listed here
| success=success, | ||
| ) | ||
|
|
||
| def project_is_active(self, url, branch_hash_or_tag): |
There was a problem hiding this comment.
This does not clarify in the evidence what is being measured.
What does a score 5 mean? We should do a little better, I think.
Here, I think that if the project receives a commit in the last 90 days it receives 1/10.
We can lower the acceptance a bit, with an explanation in evidence.
| score = self.get_score(results, "SAST") | ||
| if score >= 5: | ||
| output = "true" | ||
| evidence = f"SAST score is 5 or higher ({score})." |
There was a problem hiding this comment.
Please find out what the 5/10 means here. Evidence should clarify it.
| score = self.get_score(results, "Dependency-Update-Tool") | ||
| if score >= 5: | ||
| output = "true" | ||
| evidence = f"Dependency-Update-Tool score is 5 or higher ({score})." |
| score = self.get_score(results, "Vulnerabilities") | ||
| if score >= 5: | ||
| output = "true" | ||
| evidence = f"Vulnerabilities score is 5 or higher ({score})." |
| score = self.get_score(results, "Fuzzing") | ||
| if score >= 5: | ||
| output = "true" | ||
| evidence = f"Fuzzing score is 5 or higher ({score})." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tamasgal take a look whenever you can